Skip to content

Add an EmptyValidator #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmajano merged 5 commits into from
Jun 27, 2022
Merged

Add an EmptyValidator #61

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea90150
Add an EmptyValidator
elpete Feb 16, 2022
8d6674a
Apply cfformat changes
elpete Feb 16, 2022
7f387c4
Account for null or missing values
elpete Feb 16, 2022
4ef74ce
Apply cfformat changes
elpete Feb 16, 2022
bca68c1
trigger build
elpete Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply cfformat changes
  • Loading branch information
@elpete @actions-user
elpete authored and actions-user committed Feb 16, 2022
commit 4ef74ce1fd8fb36806fba15d697174f1804df233
2 changes: 1 addition & 1 deletion models/validators/EmptyValidator.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ component extends="BaseValidator" accessors="true" singleton {
);
}

// return true if no data to check, empty needs a data element to be checked.
// return true if no data to check, empty needs a data element to be checked.
if ( isNull( arguments.targetValue ) ) {
return true;
}
Expand Down
14 changes: 11 additions & 3 deletions test-harness/tests/specs/validators/EmptyValidatorTest.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,17 @@ component extends="coldbox.system.testing.BaseModelTest" model="cbvalidation.mod
variables.result = createMock( "cbvalidation.models.result.ValidationResult" ).init();
} );

it( "skips over null values", function() {
expect( model.validate( variables.result, this, "test", javacast( "null", "" ), true ) ).toBeTrue();
} );
it( "skips over null values", function(){
expect(
model.validate(
variables.result,
this,
"test",
javacast( "null", "" ),
true
)
).toBeTrue();
} );

describe( "empty: true", function(){
it( "passes when given an empty string", function(){
Expand Down