Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
fdb7b6c
version bump
lmajano Nov 15, 2022
ed20332
🐛 FIX: Update GHA to avoid deprecated syntax (#67)
michaelborn Dec 20, 2022
37ab311
New [Contributing](CONTRIBUTING.md) guidelines
lmajano Apr 13, 2023
640990f
Consolidated Adobe 2021 scripts into the server scripts
lmajano Apr 13, 2023
10e934a
- Fix for `tasks.json` file to include no recursion
lmajano Apr 13, 2023
dcb2a35
- New github support templates
lmajano Apr 13, 2023
c9d306f
New github action versions and consolidation of actions
lmajano Apr 13, 2023
aad99e2
Apply cfformat changes
lmajano Apr 13, 2023
4d455fc
fixing ci
lmajano Apr 13, 2023
1bd4424
Merge branch 'development' of github.com:coldbox-modules/cbvalidation…
lmajano Apr 13, 2023
f11af04
- #71 - ValidationManager errors when returning `validatedKeys` due t…
lmajano Apr 13, 2023
e56689e
more trying
lmajano Apr 13, 2023
e0e9626
resolves #45 - `Type` validator needs to be able to validate against …
lmajano Apr 13, 2023
9e6db4c
adding debugging
lmajano Apr 13, 2023
05bcdb7
more tests
lmajano Apr 13, 2023
8af1b1d
more tests
lmajano Apr 13, 2023
c0e4cd5
oops
lmajano Apr 13, 2023
5ff9220
ok done
lmajano Apr 13, 2023
c41d816
ok prepping for new and improved master release
lmajano Apr 13, 2023
9f74b1f
oops
lmajano Apr 13, 2023
7c89c03
adding coldbox be testing
lmajano Apr 14, 2023
a594ee6
fixing be builds
lmajano Apr 14, 2023
0efc5f9
typos
lmajano Apr 14, 2023
5e1497b
- The way custom validators are retrieved so they are ColdBox 7+ comp…
lmajano Apr 14, 2023
b215ca0
Apply cfformat changes
lmajano Apr 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
- New github support templates
  • Loading branch information
lmajano committed Apr 13, 2023
commit dcb2a35d96af94dfb78e7ff567cd11f24d611ed0
33 changes: 33 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
name: Bug report
about: Create a report to help us improve
---

<!-- Thanks for reporting an issue! Please fill out the blanks below. -->

## What are the steps to reproduce this issue?

1.
2.
3.

## What happens?


## What were you expecting to happen?


## Any logs, error output, etc?


## Any other comments?


## What versions are you using?

**Operating System:**
**Package Version:**
18 changes: 18 additions & 0 deletions .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
name: Feature Request
about: Request a new feature or enhancement
---

<!-- Thanks for taking the time to recommend a feature! Please fill out the form below -->

## Summary

<!-- High level description of what this feature is -->

## Detailed Description

<!-- Lets get into the weeds here -->

## Possible Implementation Ideas

<!-- If you already have some idea of how to implement this, this would be the place to put it -->
29 changes: 29 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Description

Please include a summary of the changes and which issue(s) is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

**Please note that all PRs must have tests attached to them**

IMPORTANT: Please review the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines.

## Issues

All PRs must have an accompanied issue. Please make sure you created it and linked it here.

## Type of change

Please delete options that are not relevant.

- [ ] Bug Fix
- [ ] Improvement
- [ ] New Feature
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## Checklist

- [ ] My code follows the style guidelines of this project [cfformat](../.cfformat.json)
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes