Bring back full RSpec runtime dependency #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! |
|
🚦 ⌚ |
|
🚦 💣 |
|
I see. I'll have time to fix it in few hours. |
This reverts commit 8fdd8d2. Cucumber integration relies on RSpec-core. Possibly it could be reworked but until then RSpec dependency is back.
|
Apparently Cucumber integration fully relies on RSpec. Until this changes, JsonSpec has to depend on both rspec-expectations and rspec-core. For this reason single dependency on |
|
@laserlemon Any comments on that? It actually reverts some of my merged-in changes thus fixes your master 😆 |
|
👍 |
laserlemon
added a commit
that referenced
this pull request
Jan 17, 2014
Bring back full RSpec runtime dependency
creeonix
pushed a commit
to creeonix/json_spec
that referenced
this pull request
Jan 21, 2014
Bring back full RSpec runtime dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup for 8fdd8d2.
Didn't commit by mistake. Every project which depends on JsonSpec will
refuse to run specs without that. How pity that Travis couldn't detect
this problem.