Update for RSpec 3 beta 2 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Update matcher protocol and custom matcher DSL to better align with the newer expect syntax. If you want your matchers to maintain compatibility with multiple versions of RSpec, you can alias the new names to the old. (Myron Marston) * failure_message_for_should => failure_message * failure_message_for_should_not => failure_message_when_negated * match_for_should => match * match_for_should_not => match_when_negated" http://myronmars.to/n/dev-blog/2014/02/rspec-2-99-and-3-0-beta-2-have-been-released
Contributor
Author
|
BTW how about setting RSpec to fail in case of deprecation warnings? If you don't need them to promote one syntax or another, they would be very helpful. Some pull requests (like #64) were created before beta 2 and they don't honor most recent deprecations. |
|
👍 |
Contributor
Author
|
Dependencies updated. Could anyone with an active real-life project confirm that it works well with stable RSpec 3? Tests indicate no problems. |
|
@laserlemon @skalee looks ok, can we merge it? |
|
I can confirm that this is working. |
|
Can someone merge this PR please? |
Contributor
|
Version 1.1.2 released. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support new matcher interface.
Do you prefer
aliasoralias_method? I'm usingaliasbecause it's RDoc-friendly and those matchers are not likely to be subclassed, but I can change toalias_methodif you want.Explicitly enable both expectation syntaxes.
Both fashions
something.should be_like_thisandexpect(something).to be_like_thisare used in tests so I enabled them. As in above, I can change it if you want to gradually force one or another and warnings seem helpful.