Skip to content

fix for Windows os.root() with slash error #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lefou merged 1 commit into from
Nov 15, 2023
Merged

fix for Windows os.root() with slash error #235

lefou merged 1 commit into from
Nov 15, 2023

Conversation

@philwalk
Copy link
Contributor

@philwalk philwalk commented Nov 15, 2023

This fixes #234 and adds a unit test.

@philwalk philwalk mentioned this pull request Nov 15, 2023
Closed
lefou
lefou approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou lefou merged commit fd44104 into com-lihaoyi:main Nov 15, 2023
@lefou lefou added this to the after 0.9.2 milestone Nov 15, 2023
@philwalk philwalk deleted the fix-root-slash-in-Windows branch November 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lefou lefou lefou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.3

Development

Successfully merging this pull request may close these issues.

os.root("C:/") fails in Windows

2 participants

@philwalk @lefou