Skip to content

Introduce os.SubProcess.env DynamicVariable to override default env #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lolgab merged 10 commits into from
Aug 30, 2024
Merged

Introduce os.SubProcess.env DynamicVariable to override default env #295

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f677c90
Introduce `os.proc.env` `DynamicVariable` to override default `env`
lolgab Aug 29, 2024
c7dc57f
Fix and ignore binary compatibility issues
lolgab Aug 29, 2024
9db0b1d
Change `os.proc.env` to `os.SubProcess.env`
lolgab Aug 30, 2024
75a8c51
Optimization: Avoid recreating the environment map when os.SubProcess…
lolgab Aug 30, 2024
d07f8a4
Make test verify the env variable is unset
lolgab Aug 30, 2024
da754db
Reformat
lolgab Aug 30, 2024
47cee94
Merge remote-tracking branch 'upstream/main' into env-dynamic-variable
lolgab Aug 30, 2024
c8ad9e6
Fix string literal for Scala 2.12
lolgab Aug 30, 2024
380c775
Add docs about `os.SubProcess.env`
lolgab Aug 30, 2024
927309f
Use newer syntax in readme
lolgab Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reformat
  • Loading branch information
@lolgab
lolgab committed Aug 30, 2024
commit da754db1c03b3fa0928a4740d0ac2e265375a682
3 changes: 2 additions & 1 deletion build.sc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ trait SafeDeps extends ScalaModule {
}

trait MiMaChecks extends Mima {
def mimaPreviousVersions = Seq("0.9.0", "0.9.1", "0.9.2", "0.9.3", "0.10.0", "0.10.1", "0.10.2", "0.10.3", "0.10.4")
def mimaPreviousVersions =
Seq("0.9.0", "0.9.1", "0.9.2", "0.9.3", "0.10.0", "0.10.1", "0.10.2", "0.10.3", "0.10.4")
override def mimaBinaryIssueFilters: T[Seq[ProblemFilter]] = Seq(
ProblemFilter.exclude[ReversedMissingMethodProblem]("os.PathConvertible.isCustomFs"),
// this is fine, because ProcessLike is sealed (and its subclasses should be final)
Expand Down
6 changes: 5 additions & 1 deletion os/test/src/SubprocessTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,11 @@ object SubprocessTests extends TestSuite {
if (Unix()) {
val variableName = "TEST_ENV_FOO"
val variableValue = "bar"
def envValue() = os.proc("bash", "-c", s"if [ -z $${$variableName+x} ]; then echo \"unset\"; else echo \"$$$variableName\"; fi").call().out.lines().head
def envValue() = os.proc(
"bash",
"-c",
s"if [ -z $${$variableName+x} ]; then echo \"unset\"; else echo \"$$$variableName\"; fi"
).call().out.lines().head

val before = envValue()
assert(before == "unset")
Expand Down