-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[OPIK-6838] [FE] fix: link Playground prompt versions to experiments and traces #7017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
eda8d27
feat(playground): add shared prompt-version linkage helpers (OPIK-6838)
awkoy a1c5a39
refactor(playground): reuse shared prompt-version collector in execut…
awkoy 200fd0c
fix(playground): link CHAT prompt versions on dataset experiment runs…
awkoy 5994cfc
fix(playground): keep trace prompt link on edited prompts with modifi…
awkoy 0a4e212
feat(traces): show modified badge on edited playground prompt link (O…
awkoy 3907f6b
feat(experiments): link prompt version from Configuration tab (OPIK-6…
awkoy 498c630
fix(playground): anchor TEXT prompt version + link experiment's versi…
awkoy 3d3807b
refactor(playground): extract shared resolvePromptVersionForLink help…
awkoy eab8203
refactor(experiments): simplify Configuration tab promptVersions deri…
awkoy 2c53828
refactor(playground): hoist prompt_versions request mapping to a name…
awkoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
refactor(playground): hoist prompt_versions request mapping to a name…
…d const (OPIK-6838)
- Loading branch information
commit 2c538288f62cd32430b7d52c4466f5ebc972df05
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 39-42 duplicate the
collectPromptVersionRefs(prompt)->prompt_versions/promptLibraryVersionsmapping fromusePromptDatasetItemCombination.ts; should we move this intopromptLinkage.tsas something likebuildPromptVersionsPayloadso both paths share the same{id, prompt_id?}shape?Want Baz to fix this for you? Activate Fixer