Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor(playground): hoist prompt_versions request mapping to a name…
…d const (OPIK-6838)
  • Loading branch information
awkoy committed Jun 10, 2026
commit 2c538288f62cd32430b7d52c4466f5ebc972df05
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ const runExperimentExecution = async ({
}: UseRunExperimentExecutionParams): Promise<ExperimentExecutionResponse> => {
const promptVariants = prompts.map((prompt) => {
const versionRefs = collectPromptVersionRefs(prompt);
const promptVersions = versionRefs.length
? versionRefs.map((ref) => ({ id: ref.id, prompt_id: ref.promptId }))
: undefined;
Comment on lines +39 to +42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 39-42 duplicate the collectPromptVersionRefs(prompt) -> prompt_versions/promptLibraryVersions mapping from usePromptDatasetItemCombination.ts; should we move this into promptLinkage.ts as something like buildPromptVersionsPayload so both paths share the same {id, prompt_id?} shape?

Severity

Want Baz to fix this for you? Activate Fixer


return {
model: prompt.model,
Expand All @@ -45,10 +48,7 @@ const runExperimentExecution = async ({
prompt.model,
prompt.configs as Record<string, unknown>,
),
prompt_versions:
versionRefs.length > 0
? versionRefs.map((ref) => ({ id: ref.id, prompt_id: ref.promptId }))
: undefined,
prompt_versions: promptVersions,
};
});

Expand Down
Loading