[OPIK-7183] [FE] fix: land workspace clicks on the Projects tab#7482
Merged
Conversation
…visited project Clicking a workspace routed through HomePage, which redirected into the last-visited project when one was stored. Per the Netflix request, always redirect the workspace home to the Projects tab for a consistent landing point. Last-visited project state is still tracked (back button, highlight) but no longer auto-opened. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
⏱️ pre-commit per-hook timing
⏭️ 33 skipped (no matching files changed)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Clicking a workspace dropped the user into their last-visited project instead of the workspace overview. Per the Netflix customer request, a workspace click should always land on the workspace Projects tab for a consistent, discoverable entry point.
All workspace-click entry points route through
HomePage(/$workspaceName/home), which branched on the stored last-visited project and redirected into it when present. This PR removes that branch so the workspace home always redirects to/$workspaceName/projects.HomePage.tsx— alwaysnavigate({ to: "/$workspaceName/projects" }); dropped the now-unusedactiveProjectId/isProjectLoadingreads (also removes a brief loader flicker while the project resolved).router.tsx— updated the stale route comment.Last-visited-project state is still tracked (the "Back to " button and sidebar highlighting keep working) — it is simply no longer auto-opened on a workspace click. Flows that intentionally deep-link to a project (
BackToProjectButton,ProjectSelector) bypassHomePageand are unaffected.Change checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
Testing
Ran the frontend in
--mode cometagainstdev.comet.comin theyaroslav-boikoworkspace, with a last-visited project set ("Demo chatbot", confirmed by the "Back to Demo chatbot" link):/opik/yaroslav-boiko) → redirects to the Projects tab, not the last-visited project.npm run typecheckandeslinton the changed files — both clean.Documentation
N/A — navigation behavior change; no user-facing docs affected.
🤖 Generated with Claude Code