docs: fix broken builds #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes broken documentation builds on docs.rs by removing explicit target specifications and allowing docs.rs to use its default targets. The motivation is to use windows-msvc instead of windows-gnu and aarch64-apple instead of x86_64-apple targets for better compatibility.
Key changes:
- Removes the
targetslist anddefault-targetfrom package metadata in multiple Cargo.toml files - Adds package metadata (categories and keywords) to compio-ws
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| compio/Cargo.toml | Removes default-target and targets list from docs.rs metadata |
| compio-ws/Cargo.toml | Adds categories and keywords metadata for crates.io |
| compio-runtime/Cargo.toml | Removes default-target and targets list from docs.rs metadata |
| compio-driver/Cargo.toml | Inconsistent change - removes rustdoc-args and targets but keeps default-target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Seems that I have deleted wrong lines:( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default targets of docs.rs is OK for most cases, I think.
windows-msvcinstead ofwindows-gnuaarch64-appleinstead ofx86_64-apple