Skip to content

Conversation

@bsipocz
Copy link
Contributor

@bsipocz bsipocz commented Sep 7, 2022

No description provided.

@bsipocz
Copy link
Contributor Author

bsipocz commented Sep 7, 2022

CI system seems to be due for some updates, shall I add those into this PR, or open another one, or someone else would rather do it? (being a newbie on this repo every commits of mine in this PR/or in any parallel one before merging this one have to be manually approved for CI anyway, so it's not super efficient).

@fangohr
Copy link
Member

fangohr commented Sep 7, 2022

Thank you for your contribution - looks good.

If you, or anybody, can contribute another merge request to fix the CI failure, that would be great. (I'll happily click the button to run the CI.)

@bsipocz
Copy link
Contributor Author

bsipocz commented Sep 7, 2022

I'll try to see whether I have some time for this in the evening. If you merge this PR with the breaking CI that would take care of the clicking the button part (working on a PR that has the CI running would be better for me, so I can iterate if needed without waiting for the approval after each commit).

@fangohr fangohr mentioned this pull request Sep 8, 2022
@fangohr fangohr merged commit ee98ce5 into computationalmodelling:master Sep 8, 2022
@bsipocz bsipocz deleted the patch-1 branch September 16, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants