Skip to content

Conversation

@bsipocz
Copy link
Contributor

@bsipocz bsipocz commented Sep 8, 2022

This should work around one of the CI issues. I can't yet reproduce the other one locally.

fixes #185

@bsipocz
Copy link
Contributor Author

bsipocz commented Sep 10, 2022

I suppose looking at other PRs would have been a quicker way to figure out the mpl version changes, nevertheless, I feel the addition of some verbosity for the versions is still useful, so I left all the debug commits in there.

Also, this now includes the cherry-picked commit from #183 as a way to trigger CI for that one.

@bsipocz bsipocz marked this pull request as ready for review September 10, 2022 02:18
@bsipocz bsipocz changed the title TST: Adding indirect dependency to fix CI CI: Various minor improvements to fix CI Sep 10, 2022
@bsipocz
Copy link
Contributor Author

bsipocz commented Sep 10, 2022

cc @fangohr - this is ready to go. Let me know if any of the changes are controversial and if you prefer them to be removed.

Copy link
Member

@fangohr fangohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @bsipocz, thank you for that contribution! I like the additional pip freeze debug info, moving to python 3.10, and sanitising the figure size.

Thank you @bnavigator for the sanitizing figure contribution in #183 !

I left one minor query in the code changes.

@fangohr fangohr merged commit 23066b1 into computationalmodelling:master Sep 10, 2022
@fangohr fangohr mentioned this pull request Sep 10, 2022
@bsipocz bsipocz deleted the ci_fix_and_update_versions branch June 17, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI tests are failing

3 participants