-
-
Notifications
You must be signed in to change notification settings - Fork 38
LAPACK v3.11.0 #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
LAPACK v3.11.0 #151
Conversation
avoid picking up ambient python from somewhere else in the image LAPACK_TESTING_USE_PYTHON only landed in 3.12, see Reference-LAPACK/lapack@d8f668c
…5.10.29.09.00.09 Other tools: - conda-build 25.9.0 - rattler-build 0.48.1 - rattler-build-conda-compat 1.4.9
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19007357804. Examine the logs at this URL for more detail. |
d24b41d to
56c0fe9
Compare
| :: clang.exe cannot handle /LIBPATH: in LDFLAGS, but we need that for lld-link | ||
| set "CC=clang-cl.exe" | ||
|
|
||
| python %RECIPE_DIR%\create_forwarder_dll.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We filter the symbols in this file whereas create-forwarder-dll doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean this part, right?
blas-feedstock/recipe/create_forwarder_dll.py
Lines 35 to 38 in bb5fc01
| # A crude way to filter out unwanted symbols like fprintf which should | |
| # not have been exported in netlib libraries. probably a flang bug | |
| if symbol.startswith(("c", "s", "L", "d", "z", "i", "l", "x", "C", "R")): | |
| symbols_lib_pairs.append((symbol, libname)) |
Would you be open to add this as an option in https://github.com/isuruf/create-forwarder-dll?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that part. I'm open to adding it. Maybe as a symbol filter regex?
56c0fe9 to
2569478
Compare
|
@carterbox can you run NVPL tests? |
|
Not very surprisingly (IMO), newaccelerate fails the 3.11 tests; AFAIU it only advertises compatibility with lapack 3.9. OTOH, the failures don't look catastrophically bad: However, if we do not want to simply skip those |
|
I built 2569478 natively for both NVPL and openBLAS. The tests pass. |
Redo #114, now that MKL has miraculously been unblocked