-
-
Notifications
You must be signed in to change notification settings - Fork 34
Don't use python_min in tests; allow downstream usage #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nda-forge-pinning 2025.05.13.09.46.09
|
@conda-forge-admin please rerender |
|
CPython is currently blocked on this: conda-forge/python-feedstock#777 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15006586659. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14997290220. Examine the logs at this URL for more detail. |
|
thx! |
recipe/meta.yaml
Outdated
| test: | ||
| requires: | ||
| - python {{ python_min }} # [use_noarch] | ||
| # The linter will complain about the missing python_min, but we need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a smithy option to ignore the python_min hints
recipe/meta.yaml
Outdated
| # this unpinned to allow cython to be used in the downstream tests | ||
| # of the python-feedstock. | ||
| # See also https://github.com/conda-forge/conda-forge.github.io/pull/2387 | ||
| - python # [use_noarch] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to avoid that smithy builds for each python version in the use_noarch case
| - python # [use_noarch] | |
| - python * # [use_noarch] |
…nda-forge-pinning 2025.05.13.09.46.09
|
Build is green and ready for re-review. |
h-vetinari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)