Skip to content

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented May 13, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@xhochy
Copy link
Member Author

xhochy commented May 13, 2025

@conda-forge-admin please rerender

@xhochy
Copy link
Member Author

xhochy commented May 13, 2025

CPython is currently blocked on this: conda-forge/python-feedstock#777

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented May 13, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15006586659. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14997290220. Examine the logs at this URL for more detail.

@hmaarrfk
Copy link

thx!

recipe/meta.yaml Outdated
test:
requires:
- python {{ python_min }} # [use_noarch]
# The linter will complain about the missing python_min, but we need
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a smithy option to ignore the python_min hints

recipe/meta.yaml Outdated
# this unpinned to allow cython to be used in the downstream tests
# of the python-feedstock.
# See also https://github.com/conda-forge/conda-forge.github.io/pull/2387
- python # [use_noarch]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to avoid that smithy builds for each python version in the use_noarch case

Suggested change
- python # [use_noarch]
- python * # [use_noarch]

@xhochy
Copy link
Member Author

xhochy commented May 13, 2025

Build is green and ready for re-review.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@h-vetinari h-vetinari merged commit 4de9a67 into conda-forge:main May 13, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants