Skip to content

Conversation

@quasiben
Copy link
Member

Occasionally, I and @mrocklin like to use some of the binaries in the sbin folder. Namely, the start-... scripts. This PR adds sbin folder to conda recipe and increments the build number.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@parente
Copy link
Member

parente commented May 12, 2017

@quasiben Thanks. It looks like there's a windows failure due to a missing sbin directory.

I think another way to do this is to include a patch to the pyspark setup.py to include sbin along with bin. That patch can also be a PR against Spark itself.

@quasiben
Copy link
Member Author

which path should be go down ? patch here or spark or both ? I need the sbin directory for an upcoming tutorial

@parente
Copy link
Member

parente commented May 12, 2017

Tactically, a patch here, referenced by the recipe/meta.yaml, and the same patch submitted to Spark for a long term fix so we can remove it here eventually.

@quasiben
Copy link
Member Author

quasiben commented May 12, 2017

@parente patch above moves everything in sbin/* to the bin directory. Compared with the previous copying of sbin/ to $PREFIX/sbin

@quasiben
Copy link
Member Author

Wait...that won't work. start-master.sh looks for sbin/spark-config.sh

@parente
Copy link
Member

parente commented May 16, 2017

Can the patch not copy from sbin to sbin?

@ericdill
Copy link
Member

ericdill commented Mar 7, 2018

@quasiben @parente should we close this? Seems inactive for a while now.

@oulenz
Copy link

oulenz commented Feb 27, 2019

FYI, the history server scripts in sbin have now been added to the pyspark master branch: apache/spark#23715

@parente parente closed this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants