Skip to content

Fix type definition issues in the constructors #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Fix type definition issues in the constructors #321

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07048d7
Update kafkajs.d.ts
davidkhala Apr 24, 2025
7144b76
Add type definition fixes
milindl May 22, 2025
455a3ea
Add PR number
milindl May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update kafkajs.d.ts 
constructor config mark as optional properly
  • Loading branch information
@davidkhala @milindl
davidkhala authored and milindl committed May 22, 2025
commit 07048d7a46683141ff279bb66c0b0c037aa8f62d
2 changes: 1 addition & 1 deletion types/kafkajs.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export interface CommonConstructorConfig extends GlobalConfig {
}

export class Kafka {
constructor(config: CommonConstructorConfig)
constructor(config?: CommonConstructorConfig)
producer(config?: ProducerConstructorConfig): Producer
consumer(config: ConsumerConstructorConfig): Consumer
admin(config?: AdminConstructorConfig): Admin
Expand Down