Skip to content

fix: Apply timeout correctly to consumeNum #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewhessler wants to merge 19 commits into
base: master
Choose a base branch
from
Open

fix: Apply timeout correctly to consumeNum #330

Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9a13db3
apply timeout to batch
andrewhessler Jun 8, 2025
7d6d811
allow 0 timeout in calc
andrewhessler Jun 8, 2025
adc6161
extract 1 into descriptive var
andrewhessler Jun 8, 2025
452f9c5
add bool to worker consume num
andrewhessler Aug 3, 2025
370b147
update kafka-consumer.js with bool
andrewhessler Aug 3, 2025
5f4fa5f
update arg parsing in consume num path
andrewhessler Aug 3, 2025
9b067c7
update headers
andrewhessler Aug 3, 2025
c43e99e
lint
andrewhessler Aug 3, 2025
592ba1f
add tests
andrewhessler Aug 3, 2025
2aa98ea
missed word
andrewhessler Aug 3, 2025
5914c1f
clean up
andrewhessler Aug 3, 2025
24c8cf3
last clean
andrewhessler Aug 3, 2025
6664c16
fix args error
andrewhessler Aug 3, 2025
8c88361
fix timeout
andrewhessler Aug 3, 2025
6ef3c7c
fix timeout
andrewhessler Aug 3, 2025
a64dabb
final tests
andrewhessler Aug 3, 2025
515b131
final tests
andrewhessler Aug 3, 2025
060c26e
clean up newline
andrewhessler Aug 3, 2025
2f0755b
comments
andrewhessler Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/both.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ describe('Consumer/Producer', function() {

let messageCount = 5;
for (let i = 0; i < messageCount; i++) {
setTimeout(producer.produce(topic, null, buffer, null), 500 * i);
setTimeout(() => producer.produce(topic, null, buffer, null), 500 * i);
}

const start = Date.now();
Expand Down Expand Up @@ -589,7 +589,7 @@ describe('Consumer/Producer', function() {

let messageCount = 5;
for (let i = 0; i < messageCount; i++) {
setTimeout(producer.produce(topic, null, buffer, null), 500 * i);
setTimeout(() => producer.produce(topic, null, buffer, null), 500 * i);
}

const start = Date.now();
Expand Down