Fix error in semaphore.yml #373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes a syntax error in the Semaphore CI configuration file's epilogue section.
- Corrects malformed conditional statement syntax in cache store command
- Adds debug output for LIBRDKAFKA_COMMIT_HASH variable
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| commands: | ||
| - if [[ $(command cache) ]]; then cache store "$LIBRDKAFKA_COMMIT_HASH" deps/librdkafka; done | ||
| - echo $LIBRDKAFKA_COMMIT_HASH | ||
| - if [[ $(command cache) ]]; then cache store "$LIBRDKAFKA_COMMIT_HASH" deps/librdkafka; fi |
There was a problem hiding this comment.
The command cache check may not work as intended. This will always return true if the cache command exists in PATH, regardless of whether caching is available or functional. Consider using command -v cache to check if the cache command exists, or cache --version to verify it's working properly.
Copilot uses AI. Check for mistakes.
emasab
reviewed
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #362