Skip to content

kafkatest, refactoring, and bug fixes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edenhill merged 13 commits into from
May 10, 2016
+741 −70
Merged

kafkatest, refactoring, and bug fixes #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
77305ff
Added (global) on_commit callback.
edenhill Apr 25, 2016
5433bb8
Raise exception on rebalance_cb arg building failure
edenhill Apr 25, 2016
4592b31
Improved error formatting
edenhill Apr 25, 2016
6d90fa7
Renamed producer delivery_callback to on_delivery
edenhill Apr 29, 2016
e9c9570
Minor formatting cleanup
edenhill Apr 29, 2016
b520c8d
Adjust consumer test error codes and timeouts
edenhill Apr 29, 2016
b2568b4
Restructured: C bindings are now a submodule (cimpl)
edenhill Apr 29, 2016
0dad9ef
Added kafkatest verifiable consumer and producer
edenhill Apr 29, 2016
99b774b
on_commit(): removed consumer arg
edenhill May 9, 2016
e6d3877
Minor modifications following Ewen's code review
edenhill May 9, 2016
6936d9f
Moved sources to src/ to avoid cimpl package collision
edenhill May 9, 2016
ee588bf
Minor cleanups
edenhill May 9, 2016
f853b46
test_docs: dont require module docs (cimpl)
edenhill May 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improved error formatting
  • Loading branch information
@edenhill
edenhill committed Apr 25, 2016
commit 4592b311150eb2f140e3e9b28dae6b15b97ce5b6
7 changes: 3 additions & 4 deletions confluent_kafka.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ PyObject *KafkaError_new0 (rd_kafka_resp_err_t err, const char *fmt, ...) {
va_end(ap);
}

KafkaError_init(self, err, fmt ? buf : NULL);
KafkaError_init(self, err, fmt ? buf : rd_kafka_err2str(err));

return (PyObject *)self;
}
Expand All @@ -257,11 +257,10 @@ PyObject *KafkaError_new0 (rd_kafka_resp_err_t err, const char *fmt, ...) {
* @brief Internal factory to create KafkaError object.
* @returns a new KafkaError object if \p err != 0, else a None object.
*/
static PyObject *KafkaError_new_or_None (rd_kafka_resp_err_t err,
const char *str) {
PyObject *KafkaError_new_or_None (rd_kafka_resp_err_t err, const char *str) {
if (!err)
Py_RETURN_NONE;
return KafkaError_new0(err, str);
return KafkaError_new0(err, "%s", str);
}


Expand Down
1 change: 1 addition & 0 deletions confluent_kafka.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
extern PyObject *KafkaException;

PyObject *KafkaError_new0 (rd_kafka_resp_err_t err, const char *fmt, ...);
PyObject *KafkaError_new_or_None (rd_kafka_resp_err_t err, const char *str);


/**
Expand Down