Skip to content

Added error callback for propagating generic errors from librdkafka to app #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edenhill merged 5 commits into from
Aug 4, 2016
Merged

Added error callback for propagating generic errors from librdkafka to app #15

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fdaa0d4
Refactor Consumer and Producer into common Handle for code reuse.
edenhill Jul 6, 2016
0e7b694
Added error_cb for propagating generic errors from librdkafka to app …
edenhill Jul 6, 2016
fa80712
Added unit-test for error_cb
edenhill Jul 13, 2016
d7239ee
Documented parameters of callbacks
edenhill Jul 13, 2016
353ac3f
Make sure to GC on_commit callable
edenhill Aug 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make sure to GC on_commit callable
  • Loading branch information
@edenhill
edenhill committed Aug 4, 2016
commit 353ac3f4dfac0da2ab5004a3887d60c1bad00b30
2 changes: 2 additions & 0 deletions confluent_kafka/src/Consumer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ static int Consumer_traverse (Handle *self,
Py_VISIT(self->u.Consumer.on_assign);
if (self->u.Consumer.on_revoke)
Py_VISIT(self->u.Consumer.on_revoke);
Copy link
Contributor

@ewencp ewencp Jul 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing visiting on_commit?

if (self->u.Consumer.on_commit)
Py_VISIT(self->u.Consumer.on_commit);

Handle_traverse(self, visit, arg);

Expand Down