Skip to content

Conversation

@mieciu
Copy link
Contributor

@mieciu mieciu commented Oct 18, 2016

Following issue #47 I'd like to suggest introducing tox as a testing tool.

Feel free to install tox (with pip) and simply run tox from the root directory. It will download both pytest and flake automatically for you.

Please note that this PR is just a loose suggestion. I'd like to hear some kind of feedback from project maintainers to have green light on polishing this further on.

@ghost
Copy link

ghost commented Oct 18, 2016

It looks like @mieciu hasn't signed our Contributor License Agreement, yet.

Appreciation of efforts,

clabot

@edenhill
Copy link
Contributor

edenhill commented Nov 2, 2016

This looks good.
@ewencp Any comments?
@mieciu Can you sign the CLA?

@ewencp
Copy link
Contributor

ewencp commented Nov 7, 2016

@mieciu Sorry, CLABot is misbehaving. You can find the CLA to sign here.

tox file looks good and I've tested. We've definitely got some flake8 cleanup to do. Testing on 3.5.2 is also testing, but just to get the tox changes in, this LGTM. Other potentially missing piece is something in a README, although finding how to set this up wasn't all that tough and probably many python library devs are already familiar.

@edenhill
Copy link
Contributor

edenhill commented Nov 8, 2016

Yes, please add Tox setup instructions in tests/README.md
Thanks

@edenhill edenhill changed the base branch from master to dev November 8, 2016 20:30
@edenhill edenhill closed this Nov 8, 2016
@edenhill edenhill changed the base branch from dev to master November 8, 2016 21:33
@edenhill edenhill reopened this Nov 8, 2016
@edenhill
Copy link
Contributor

edenhill commented Nov 8, 2016

Whoops, didnt mean to close it.
@mieciu If you sign the CLA we'd be happy to merge this.

@mieciu
Copy link
Contributor Author

mieciu commented Nov 14, 2016

I've just signed the CLA and updated README sections you were asking for.

@edenhill
Copy link
Contributor

Awesome, thanks for this!

@edenhill
Copy link
Contributor

Also +1 for squashing your commits :)

@edenhill edenhill merged commit bbe7c90 into confluentinc:master Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants