Skip to content

Conversation

@emasab
Copy link
Contributor

@emasab emasab commented Jan 26, 2023

No description provided.

milindl and others added 7 commits January 5, 2023 10:10
…n != 10

Using the --dump-files option on clang-format-10, this guards against
any changes to the defaults, or changes to the 'BasedOnStyle' styles.
For .clang-format-cpp, because of the way we are using it in the script
by converting it to the key/value format, a number of options from the
--dump-files option has to be omitted, hence why we need to retain
the BasedOnStyle. For .clang-format, we no longer need this.

Additionally, style-format.sh warns in case clang-format version is
not 10.x.y.
RD_KAFKA_TOPIC_F_LEADER_UNAVAIL
@emasab emasab changed the base branch from master to feature/kip320 January 26, 2023 16:40
@emasab emasab changed the base branch from feature/kip320 to master January 26, 2023 16:43
@emasab emasab changed the base branch from master to feature/kip320 January 26, 2023 16:43
@emasab emasab requested a review from milindl January 26, 2023 17:15
Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some issue with style-format, perhaps a merge issue from some commit

@emasab emasab merged commit 73a371a into feature/kip320 Jan 27, 2023
@emasab emasab deleted the feature/delegate-to-leader-on-metadata-refresh branch January 27, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants