Replace coapp with zip package #4244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that uses backslashes in Windows PowerShell 1.0
pranavrth
approved these changes
Apr 3, 2023
|
|
||
| Copy-Item "${srcdir}\librdkafka.lib","${srcdir}\librdkafkacpp.lib" -Destination $libdir | ||
|
|
||
| 7z.exe a "artifacts\librdkafka.redist.zip" "build" |
There was a problem hiding this comment.
How do we make sure that 7z.exe is present?
There was a problem hiding this comment.
This can be an agent requirement, as for Visual Studio it was already installed. Unfortunately in given PowerShell version (Windows PowerShell 1.0), Compress-Archive is flawed as it uses backslashes.
| } | ||
|
|
||
| cd vcpkg | ||
| # latest version is having an issue while doing vcpkg integrate install |
There was a problem hiding this comment.
Let's take one ticket to check this.
| @@ -0,0 +1,46 @@ | |||
| <# | |||
There was a problem hiding this comment.
Need some understanding on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coapp project is discontinued, this PR replaces the intermediate nuget package with a zip package that contains Windows dlls and libs to include into the final nupkg.