Add unit tests for blocking pool filter, fix doc inconsistencies#4
Merged
cong-or merged 1 commit intocong-or:mainfrom Mar 18, 2026
Merged
Conversation
Add 9 unit tests for `is_blocking_pool_stack()` covering the blocking pool detection logic from issue cong-or#3. This function went through multiple release iterations (v0.4.2–v0.5.0) but had zero test coverage. Fix TROUBLESHOOTING.md listing 3 worker discovery steps when the actual implementation and ARCHITECTURE.md document 4. Fix README.md stating "x86_64 architecture" when ARCHITECTURE.md and DEVELOPMENT.md both document x86_64/aarch64 support. // ticktockbent
Owner
|
Thanks @TickTockBent , really appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds 9 unit tests for
is_blocking_pool_stack()and fixes a couple doc inconsistencies I noticed while reading through the codebase.Tests
The blocking pool filter went through four release iterations (v0.4.2 through v0.5.0) to get right, but had no test coverage. These tests pin down the current behavior:
spawn_blockingstacks (withInner::run, without worker scheduler) are filteredstarts_withandcontainsmatching work correctly for closure wrappers and different Tokio versionsspawn_blocking, bcrypt on a worker thread)All 64 tests pass, clippy clean, fmt clean.
Doc fixes
TROUBLESHOOTING.md: The "Workers: 0" section listed 3 discovery steps but the code and ARCHITECTURE.md document 4 (the explicit
--workersprefix step was missing). Updated to match.README.md: Requirements listed "x86_64 architecture" but ARCHITECTURE.md and DEVELOPMENT.md both say x86_64/aarch64. Updated to match.
// ticktockbent