Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 44.41% 44.41%
=======================================
Files 9 9
Lines 403 403
=======================================
Hits 179 179
Misses 190 190
Partials 34 34
Continue to review full report at Codecov.
|
Member
|
Please squash the commits and make sure the commit is signed |
mikebrow
approved these changes
Mar 21, 2022
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
LGTM
just need squash and sign comm
Signed-off-by: Michael Zappa <Michael.Zappa@stateless.net>
MikeZappa87
force-pushed
the
bug/fixloversion
branch
from
8e931cf to
9ebcec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed this when adding the CHECK code to go-cni. @mikebrow and I have been talking about how we can move forward with this. We decided to update the version and come up with a plan to possibly remove this with the goal to be explicitly added. This is also a conversation the CNI maintainers have had as well! More to come!