Skip to content

Use revive instead of golint #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzys merged 1 commit into from
Apr 26, 2022
Merged

Use revive instead of golint #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use revive instead of golint 
Signed-off-by: Wang Bing <wangbing.adam@gmail.com>
  • Loading branch information
@pigletfly
pigletfly committed Apr 19, 2022
commit 322e8bfbe6917a4343bc355f5a7f0525e0007099
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:

- uses: golangci/golangci-lint-action@v3
with:
version: v1.29
version: v1.45.2
working-directory: src/github.com/containerd/go-cni

tests:
Expand Down
2 changes: 1 addition & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ linters:
- unconvert
- gofmt
- goimports
- golint
- revive
- ineffassign
- vet
- unused
Expand Down
4 changes: 2 additions & 2 deletions deprecated.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ package cni
import types100 "github.com/containernetworking/cni/pkg/types/100"

// Deprecated: use cni.Opt instead
type CNIOpt = Opt //nolint: golint // type name will be used as cni.CNIOpt by other packages, and that stutters
type CNIOpt = Opt //revive:disable // type name will be used as cni.CNIOpt by other packages, and that stutters

// Deprecated: use cni.Result instead
type CNIResult = Result //nolint: golint // type name will be used as cni.CNIResult by other packages, and that stutters
type CNIResult = Result //revive:disable // type name will be used as cni.CNIResult by other packages, and that stutters

// GetCNIResultFromResults creates a Result from the given slice of types100.Result,
// adding structured data containing the interface configuration for each of the
Expand Down