Support Labels for networks and volumes#274
Merged
Merged
Conversation
AkihiroSuda
reviewed
Jun 30, 2021
fahedouch
force-pushed
the
labels
branch
7 times, most recently
from
ce16674 to
593bab6
Compare
AkihiroSuda
reviewed
Jul 5, 2021
AkihiroSuda
reviewed
Jul 5, 2021
| // DataDirName is "_data" | ||
| const DataDirName = "_data" | ||
|
|
||
| const volumeFileName = "volume.json" |
Member
There was a problem hiding this comment.
const volumeJSONFileName, or volumeMetaFileName
AkihiroSuda
reviewed
Jul 5, 2021
| labelsMap := strutil.ConvertKVStringsToMap(labels) | ||
|
|
||
| volumeOpts := make(map[string]interface{}) | ||
| volumeOpts["nerdctlLabels"] = labelsMap |
Member
There was a problem hiding this comment.
Just labels is fine for volumes, as we own the entire JSON by ourselves
Member
There was a problem hiding this comment.
And better to define a struct
AkihiroSuda
reviewed
Jul 5, 2021
|
|
||
| func NerdctlLabels(b []byte) *map[string]string { | ||
| type nerdctlConfigList struct { | ||
| NerdctlLabels *map[string]string `json:"nerdctlLabels,omitempty"` |
AkihiroSuda
reviewed
Jul 5, 2021
| type ConfigListTemplateOpts struct { | ||
| ID int | ||
| Name string // e.g. "nerdctl" | ||
| Labels string // e.g. `,{"group":"bigger"}` |
Member
Author
There was a problem hiding this comment.
it was just an example, I changed to a more meaningful example
AkihiroSuda
reviewed
Jul 5, 2021
| type ConfigListTemplateOpts struct { | ||
| ID int | ||
| Name string // e.g. "nerdctl" | ||
| Labels string // e.g. `,{"group":"bigger"}` |
fahedouch
force-pushed
the
labels
branch
3 times, most recently
from
c3350ce to
56c294b
Compare
AkihiroSuda
reviewed
Jul 6, 2021
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
This was referenced Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue #258