Skip to content

Add --allow option in build#2746

Merged
AkihiroSuda merged 1 commit into
containerd:mainfrom
yankay:add-build-flag-allow
Jan 12, 2024
Merged

Add --allow option in build#2746
AkihiroSuda merged 1 commit into
containerd:mainfrom
yankay:add-build-flag-allow

Conversation

@yankay
Copy link
Copy Markdown
Contributor

@yankay yankay commented Jan 11, 2024

fixes: #2744

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment thread docs/command-reference.md Outdated
- :whale: `type=image,name=example.com/image,push=true`: Push to a registry (see [`buildctl build`](https://github.com/moby/buildkit/tree/v0.9.0#imageregistry) documentation)
- :whale: `--progress=(auto|plain|tty)`: Set type of progress output (auto, plain, tty). Use plain to show container output
- :whale: `--secret`: Secret file to expose to the build: id=mysecret,src=/local/secret
- :whale: `--allow`: Allow extra privileged entitlement, e.g. network.host, security.insecure
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have a link to how to configure the entitlements
https://github.com/moby/buildkit/blob/master/docs/buildkitd.toml.md

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AkihiroSuda

The docs has been added :-)

buildCommand.Flags().StringP("output", "o", "", "Output destination (format: type=local,dest=path)")
buildCommand.Flags().String("progress", "auto", "Set type of progress output (auto, plain, tty). Use plain to show container output")
buildCommand.Flags().StringArray("secret", nil, "Secret file to expose to the build: id=mysecret,src=/local/secret")
buildCommand.Flags().StringArray("allow", nil, "Allow extra privileged entitlement, e.g. network.host, security.insecure")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a shell completion?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AkihiroSuda
Shell completion has been added :-)

@AkihiroSuda AkihiroSuda added this to the v2.0.0 (tentative) milestone Jan 12, 2024
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay force-pushed the add-build-flag-allow branch from 9c863d2 to 5ee55f2 Compare January 12, 2024 02:55
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yankay yankay closed this Jan 12, 2024
@yankay yankay reopened this Jan 12, 2024
@AkihiroSuda AkihiroSuda merged commit 6b68937 into containerd:main Jan 12, 2024
@AkihiroSuda AkihiroSuda modified the milestones: v2.0.0, v1.7.3 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nerdctl build lacks --allow

2 participants