run with pidfile option#311
Merged
Merged
Conversation
AkihiroSuda
reviewed
Aug 10, 2021
AkihiroSuda
reviewed
Aug 10, 2021
AkihiroSuda
reviewed
Aug 11, 2021
Contributor
Author
|
I think this time we are ready for the big moment @AkihiroSuda, this will be my first PR for the nerdctl and I'm so excited about this 🥳😋 |
AkihiroSuda
requested changes
Aug 12, 2021
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Sorry, this has to be implemented in pkg/ocihook to support restarting like podman:
$ podman run -d --name foo --restart=always --pidfile /tmp/foo.pid nginx:alpine
$ cat /tmp/foo.pid
41021
$ kill -9 41021
$ cat /tmp/foo.pid
41100
Contributor
Author
I did something about OCI hook for supporting |
AkihiroSuda
reviewed
Aug 14, 2021
AkihiroSuda
reviewed
Aug 14, 2021
AkihiroSuda
reviewed
Aug 14, 2021
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Contributor
Author
|
any updates @AkihiroSuda 🤝 |
AkihiroSuda
approved these changes
Aug 18, 2021
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM, and pushed a small fix
Sorry for my recent delay in reviewing PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
I'm not so sure but It might fix the second option of issue #215.