Rename containerd-rootless-setuptool.sh#3449
Closed
abitrolly wants to merge 2 commits into
Closed
Conversation
containerd-rootless-setuptool.sh is now containerd-rootless-systemd.sh Signed-off-by: Anatoli Babenia <anatoli@rainforce.org>
fastmod -F -- "-setuptool" "-systemd" Signed-off-by: Anatoli Babenia <anatoli@rainforce.org>
Member
|
Hi @abitrolly, I don't think is a good idea to suffix the script name by |
Contributor
Author
|
@fahedouch then it is probably |
Member
|
For the sake of compatibility the script name shouldn’t be changed unless there is an extremely convincing reason. Also, the script may potentially support non-systemd inits (if somebody works on it). So I’m rejecting this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containerd-rootless-setuptool.shis nowcontainerd-rootless-systemd.shTo clarify what this tool does.
Closes #66.