Skip to content

Print message if container is not running.#44

Merged
AkihiroSuda merged 1 commit into
containerd:masterfrom
shishir-a412ed:kill_msg
Dec 14, 2020
Merged

Print message if container is not running.#44
AkihiroSuda merged 1 commit into
containerd:masterfrom
shishir-a412ed:kill_msg

Conversation

@shishir-a412ed
Copy link
Copy Markdown
Contributor

Signed-off-by: Shishir Mahajan smahajan@roblox.com

Signed-off-by: Shishir Mahajan <smahajan@roblox.com>
@shishir-a412ed
Copy link
Copy Markdown
Contributor Author

Catching up a bit late on #41 changes, but IMO we should keep the behavior closer to docker behavior.

This is docker behavior when we try to kill a stopped container.

SM-smahajan628:~ smahajan$ docker kill 1ed12c6567b8
Error response from daemon: Cannot kill container: 1ed12c6567b8: Container 1ed12c6567b81a2ad417a464fcee7fcacd6e4c7dae956985233f1bfec5afb269 is not running

/cc @AkihiroSuda @fuweid

@AkihiroSuda AkihiroSuda merged commit b6c45a3 into containerd:master Dec 14, 2020
@shishir-a412ed shishir-a412ed deleted the kill_msg branch December 16, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants