add healthcheck orchestration logic#4427
Merged
AkihiroSuda merged 1 commit intoSep 22, 2025
Merged
Conversation
coderbirju
force-pushed
the
automate_health_checks_feat
branch
15 times, most recently
from
a4676a1 to
bba6059
Compare
coderbirju
force-pushed
the
automate_health_checks_feat
branch
from
bba6059 to
97643eb
Compare
coderbirju
force-pushed
the
automate_health_checks_feat
branch
3 times, most recently
from
f4fc171 to
f12e708
Compare
Contributor
Author
|
@swagatbora90 @Shubhranshu153 @AkihiroSuda PTAL when you get a chance, open to improvements |
AkihiroSuda
reviewed
Aug 28, 2025
ChengyuZhu6
reviewed
Aug 28, 2025
Contributor
Author
|
Hi @AkihiroSuda yes we can move this for v2.1.5, I want to get in some more robust testing before we merge this |
coderbirju
force-pushed
the
automate_health_checks_feat
branch
2 times, most recently
from
87f6fa0 to
3480422
Compare
Contributor
Author
|
Just a few more minor tests to be added, then this PR should be ready to merge, will try and get those in the next couple of days |
coderbirju
force-pushed
the
automate_health_checks_feat
branch
3 times, most recently
from
f3e94d4 to
9b4b4b7
Compare
coderbirju
changed the title
Contributor
Author
|
There are some issues running systemd inside the Rootless test environment, fails with For now I have skipped the tests in rootless mode and added documentation for the same, I will add a seprate follow-up PR to fix these issues but i'd like to get this reviewed and merged. Current failures seem to be unrelated to healthchecks |
coderbirju
force-pushed
the
automate_health_checks_feat
branch
from
3a56334 to
7f350cd
Compare
coderbirju
requested review from
AkihiroSuda,
Shubhranshu153 and
swagatbora90
Shubhranshu153
approved these changes
Sep 17, 2025
AkihiroSuda
reviewed
Sep 17, 2025
AkihiroSuda
reviewed
Sep 17, 2025
AkihiroSuda
reviewed
Sep 17, 2025
AkihiroSuda
requested changes
Sep 17, 2025
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Please squash the commits
https://lima-vm.io/docs/dev/git/#squashing-commits
swagatbora90
approved these changes
Sep 18, 2025
coderbirju
force-pushed
the
automate_health_checks_feat
branch
2 times, most recently
from
c2a14b0 to
ee67008
Compare
Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
coderbirju
force-pushed
the
automate_health_checks_feat
branch
from
ee67008 to
7216405
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to add orchestration logic to nerdctl healthchecks
This PR uses systemd timers to orchestrate healthcheks in nerdctl without the need for a daemon process. Feature currently scoped for rootful linux systems.