-
Notifications
You must be signed in to change notification settings - Fork 179
add support for nodes query #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, Boris. Thanks for contributing! As discussed internally, at the moment, we're trying to minimize the number of tools the MCP server exposes to avoid problems with smaller models or taking up too much of the token context window budget. In this PR you're introducing multiple CRUD tools that the LLM should not need since it should be able to leverage the generic resource tools. IMHO the only tool that brings something new and would be impossible to replace with current tooling is the one to retrieve the node logs. We should only keep this one. |
+1 here |
|
removed all the tools except log |
|
@blublinsky thanks for the PR and addressing our comments |
e6307ae to
ff11649
Compare
add support for nodes logs Signed-off-by: blublinsky <[email protected]>
Signed-off-by: blublinsky <[email protected]>
|
I tested w/ the |
This PR is adding supports for getting information about kubernetes cluster nodes