Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adapt tests to the new toolsetconfig
Signed-off-by: Alberto Gutierrez <[email protected]>
  • Loading branch information
aljesusg committed Nov 5, 2025
commit e7f6ff931341d78cd569de0bdbc8591a8c7e426b
24 changes: 14 additions & 10 deletions pkg/kubernetes-mcp-server/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -292,16 +292,20 @@ func (m *MCPServerOptions) Validate() error {
klog.Warningf("authorization-url is using http://, this is not recommended production use")
}
}
/* If Kiali tools are enabled, validate Kiali toolset configuration */
if slices.Contains(m.StaticConfig.Toolsets, "kiali") {
cfg, ok := m.StaticConfig.GetToolsetConfig("kiali")
if !ok {
return fmt.Errorf("kiali configuration is required when kiali tools are enabled")
}
if err := cfg.Validate(); err != nil {
return fmt.Errorf("invalid kiali configuration: %w", err)
}
}
/* If Kiali tools are enabled, validate Kiali toolset configuration */
if slices.Contains(m.StaticConfig.Toolsets, "kiali") {
cfg, ok := m.StaticConfig.GetToolsetConfig("kiali")
if !ok {
return fmt.Errorf("kiali-url is required when kiali tools are enabled")
}
if err := cfg.Validate(); err != nil {
// Normalize error message for missing URL to match expected UX/tests
if strings.Contains(err.Error(), "kiali-url is required") {
return fmt.Errorf("kiali-url is required when kiali tools are enabled")
}
return fmt.Errorf("invalid kiali configuration: %w", err)
}
}
return nil
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
toolsets = ["core", "kiali"]

[kiali]
[toolset_configs.kiali]
url = "http://kiali"