-
Notifications
You must be signed in to change notification settings - Fork 168
feat(core): add cluster health check tool #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Output format: ===============================================
|
2e02dc9 to
767c1db
Compare
pkg/toolsets/core/health_check.go
Outdated
| // Fallback: Get server version | ||
| // Note: This would require access to discovery client which isn't exposed in params | ||
| // For now, return empty string | ||
| return "", fmt.Errorf("unable to determine cluster version") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this only is OCP?
|
I'm not really sure about this one, it seems to be quite opinionated. In https://github.com/Flux159/mcp-server-kubernetes they're implementing similar functionality via a prompt. Which doesn't seem like a bad idea. Similarly, in https://github.com/GoogleCloudPlatform/kubectl-ai (AFAIU) they're leveraging the system prompt for this purpose: https://github.com/GoogleCloudPlatform/kubectl-ai/blob/main/pkg/agent/systemprompt_template_default.txt IMO if we want to proceed with this feature we should either:
This is also a good case to test evals and see if they can be used to make a better decision on how to implement this feature. |
1d70e69 to
5fd5987
Compare
Signed-off-by: Rohit Patil <[email protected]>
Signed-off-by: Rohit Patil <[email protected]>
Signed-off-by: Rohit Patil <[email protected]>
5fd5987 to
afb7d63
Compare
Hi Team,
Can you PTAL on this.
PR about:
Implements comprehensive cluster health check tool that examines:
Features: