Skip to content

Conversation

@olliewalsh
Copy link
Collaborator

@olliewalsh olliewalsh commented Nov 5, 2025

Enables vulkan on the cuda image and adds required runtime dependencies

Summary by Sourcery

Enable Vulkan on the CUDA container image by updating build scripts and Containerfile to install Vulkan packages, configure necessary RHEL streams and EPEL repos, and set the GGML_VULKAN CMake flag.

New Features:

  • Enable Vulkan support in CUDA builds by adding the GGML_VULKAN CMake flag

Enhancements:

  • Install Vulkan runtime dependencies (vulkan, vulkan-tools, mesa-libEGL, libXext) in the CUDA image
  • Configure RHEL-based sysroots by adding EPEL, AppStream, BaseOS, and CRB repositories

Build:

  • Update build_llama_and_whisper.sh to install Vulkan RPMs in dnf_install_cuda

Signed-off-by: Oliver Walsh <[email protected]>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enables Vulkan support in the CUDA-based container image by updating build scripts to include Vulkan RPMs and CMake flags, and extending the CUDA Containerfile to install necessary runtime Vulkan dependencies with appropriate repository setup.

File-Level Changes

Change Details Files
Enable Vulkan RPM installation in the build script
  • Conditional RHEL handling: enable EPEL, AppStream, BaseOS, CRB repos
  • Install Vulkan RPMs in dnf_install_cuda
container-images/scripts/build_llama_and_whisper.sh
Add Vulkan flag to CMake configuration for CUDA builds
  • Append -DGGML_VULKAN=1 to common_flags alongside -DGGML_CUDA=ON
container-images/scripts/build_llama_and_whisper.sh
Install Vulkan runtime dependencies in CUDA Containerfile
  • Copy and source lib.sh to set up EPEL and stream repos
  • Install vulkan, vulkan-tools, mesa-libEGL, libXext
  • Remove non-UBI repos cleanup
container-images/cuda/Containerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rhatdan
Copy link
Member

rhatdan commented Nov 10, 2025

@olliewalsh is this still a draft?

@olliewalsh
Copy link
Collaborator Author

@olliewalsh is this still a draft?

Yes, want to add some docs

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants