-
Notifications
You must be signed in to change notification settings - Fork 286
Add comprehensive uninstall instructions to README #2245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add detailed uninstall section covering all installation methods - Document pip uninstall command - Document Fedora DNF removal command - Document macOS pkg uninstaller steps - Add instructions for removing user data and configuration files - Document locations of artifacts in home directory (~/.local/share/ramalama and ~/.config/ramalama) - Update 'In development' section to reference new uninstall instructions Fixes containers#2243 Signed-off-by: Daniel J Walsh <[email protected]>
Reviewer's GuideAdds a dedicated uninstall section to the README with concrete commands for pip, Fedora (DNF), macOS pkg installs, and user data cleanup, and updates the existing "In development" section to reference these centralized instructions instead of duplicating uninstall steps. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- For the macOS uninstall section, consider adding a brief note that the
/usr/local/*paths may differ for users who installed to a custom prefix (e.g., via Homebrew or a non-default$PREFIX), so they know to adjust the paths rather than copy-pasting blindly. - In the macOS uninstall snippet, you could reduce the risk of accidental copy-paste damage by grouping the optional
rmcommands behind a short explanatory paragraph or comment (e.g., “Run only those lines that match what you have installed”), making it clearer that not all lines will apply to every installation.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For the macOS uninstall section, consider adding a brief note that the `/usr/local/*` paths may differ for users who installed to a custom prefix (e.g., via Homebrew or a non-default `$PREFIX`), so they know to adjust the paths rather than copy-pasting blindly.
- In the macOS uninstall snippet, you could reduce the risk of accidental copy-paste damage by grouping the optional `rm` commands behind a short explanatory paragraph or comment (e.g., “Run only those lines that match what you have installed”), making it clearer that not all lines will apply to every installation.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@noahbliss PTAL |
|
/retest ramalama-on-pull-request |
|
/retest bats-on-pull-request |
olliewalsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #2243
Summary by Sourcery
Document comprehensive uninstall procedures and data cleanup steps for RamaLama across supported installation methods.
Documentation: