Skip to content

Conversation

@rhatdan
Copy link
Member

@rhatdan rhatdan commented Dec 15, 2025

  • Add detailed uninstall section covering all installation methods
  • Document pip uninstall command
  • Document Fedora DNF removal command
  • Document macOS pkg uninstaller steps
  • Add instructions for removing user data and configuration files
  • Document locations of artifacts in home directory (~/.local/share/ramalama and ~/.config/ramalama)
  • Update 'In development' section to reference new uninstall instructions

Fixes #2243

Summary by Sourcery

Document comprehensive uninstall procedures and data cleanup steps for RamaLama across supported installation methods.

Documentation:

  • Add a dedicated uninstall section to the README covering pip, Fedora DNF, and macOS pkg installations, including removal of binaries, supporting files, and optional artifacts.
  • Describe how to remove RamaLama user data and configuration directories, including large model data in the home directory.
  • Update the development status section to reference the new uninstall documentation for resetting installations.

- Add detailed uninstall section covering all installation methods
- Document pip uninstall command
- Document Fedora DNF removal command
- Document macOS pkg uninstaller steps
- Add instructions for removing user data and configuration files
- Document locations of artifacts in home directory (~/.local/share/ramalama and ~/.config/ramalama)
- Update 'In development' section to reference new uninstall instructions

Fixes containers#2243

Signed-off-by: Daniel J Walsh <[email protected]>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 15, 2025

Reviewer's Guide

Adds a dedicated uninstall section to the README with concrete commands for pip, Fedora (DNF), macOS pkg installs, and user data cleanup, and updates the existing "In development" section to reference these centralized instructions instead of duplicating uninstall steps.

File-Level Changes

Change Details Files
Introduce a dedicated uninstall section documenting commands for different installation methods and user data cleanup locations.
  • Add pip-based uninstall instructions using pip uninstall ramalama.
  • Add Fedora uninstall instructions using sudo dnf remove ramalama.
  • Document macOS .pkg uninstall steps including removal of binaries, shared data, man pages, and shell completions under /usr/local.
  • Add guidance for removing user data and configuration directories in the home directory, plus root-owned data under /var/lib/ramalama.
  • Warn that the model data directory can be large and should be removed with care.
README.md
Refactor the existing "In development" section to rely on the new uninstall documentation instead of inline reset commands.
  • Remove inline commands for deleting /var/lib/ramalama and $HOME/.local/share/ramalama.
  • Replace them with a reference link to the new uninstall section for full removal and cleanup instructions.
README.md

Assessment against linked issues

Issue Objective Addressed Explanation
#2243 Add clear uninstall instructions to the README that explain how to fully remove the software and its artifacts.

Possibly linked issues

  • Uninstall Instructions? #2243: PR implements the requested README uninstall instructions, covering package removal and data/config cleanup across platforms.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • For the macOS uninstall section, consider adding a brief note that the /usr/local/* paths may differ for users who installed to a custom prefix (e.g., via Homebrew or a non-default $PREFIX), so they know to adjust the paths rather than copy-pasting blindly.
  • In the macOS uninstall snippet, you could reduce the risk of accidental copy-paste damage by grouping the optional rm commands behind a short explanatory paragraph or comment (e.g., “Run only those lines that match what you have installed”), making it clearer that not all lines will apply to every installation.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For the macOS uninstall section, consider adding a brief note that the `/usr/local/*` paths may differ for users who installed to a custom prefix (e.g., via Homebrew or a non-default `$PREFIX`), so they know to adjust the paths rather than copy-pasting blindly.
- In the macOS uninstall snippet, you could reduce the risk of accidental copy-paste damage by grouping the optional `rm` commands behind a short explanatory paragraph or comment (e.g., “Run only those lines that match what you have installed”), making it clearer that not all lines will apply to every installation.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan
Copy link
Member Author

rhatdan commented Dec 15, 2025

@noahbliss PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Dec 16, 2025

@olliewalsh
Copy link
Collaborator

/retest ramalama-on-pull-request

@olliewalsh
Copy link
Collaborator

/retest bats-on-pull-request

Copy link
Collaborator

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olliewalsh olliewalsh merged commit 202901e into containers:main Dec 17, 2025
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uninstall Instructions?

2 participants