Skip to content

rocm: reduce image size by using a multi-stage build #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikebonnet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rocm: reduce image size by using a multi-stage build #2246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion container-images/rocm/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,24 @@
FROM quay.io/fedora/fedora:43
FROM quay.io/fedora/fedora:43 AS builder

COPY container-images/scripts/build_llama_and_whisper.sh \
container-images/scripts/lib.sh \
/src/
WORKDIR /src/
RUN ./build_llama_and_whisper.sh rocm

FROM quay.io/fedora/fedora:43

COPY --from=builder \
/tmp/install/bin/llama-bench \
/tmp/install/bin/llama-perplexity \
/tmp/install/bin/llama-quantize \
/tmp/install/bin/llama-server \
/tmp/install/bin/rpc-server \
/tmp/install/bin/whisper-server \
/usr/bin/
COPY --from=builder /tmp/install/lib64/*.so /usr/lib64/

RUN dnf -y --setopt=install_weak_deps=false install hipblas rocblas rocm-hip rocm-runtime rocsolver && \
dnf -y clean all

WORKDIR /
7 changes: 2 additions & 5 deletions container-images/scripts/build_llama_and_whisper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ cmake_steps() {
}

set_install_prefix() {
if [ "$containerfile" = "cuda" ] || [ "$containerfile" = "intel-gpu" ] || [ "$containerfile" = "cann" ] || [ "$containerfile" = "musa" ]; then
if [ "$containerfile" = "cuda" ] || [ "$containerfile" = "intel-gpu" ] || [ "$containerfile" = "cann" ] || [ "$containerfile" = "musa" ] || [ "$containerfile" = "rocm" ]; then
echo "/tmp/install"
else
echo "/usr"
Expand All @@ -203,7 +203,7 @@ configure_common_flags() {
common_flags+=("-DCMAKE_HIP_COMPILER_ROCM_ROOT=/usr")
fi

common_flags+=("-DGGML_HIP=ON" "-DAMDGPU_TARGETS=${AMDGPU_TARGETS:-gfx1010,gfx1012,gfx1030,gfx1032,gfx1100,gfx1101,gfx1102,gfx1103,gfx1151,gfx1200,gfx1201}")
common_flags+=("-DGGML_HIP=ON" "-DGPU_TARGETS=${GPU_TARGETS:-gfx1010,gfx1012,gfx1030,gfx1032,gfx1100,gfx1101,gfx1102,gfx1103,gfx1151,gfx1200,gfx1201}")
;;
cuda)
common_flags+=("-DGGML_CUDA=ON" "-DCMAKE_EXE_LINKER_FLAGS=-Wl,--allow-shlib-undefined" "-DCMAKE_CUDA_FLAGS=\"-U__ARM_NEON -U__ARM_NEON__\"")
Expand Down Expand Up @@ -234,7 +234,6 @@ clone_and_build_whisper_cpp() {

git_clone_specific_commit "${WHISPER_CPP_REPO:-https://github.com/ggerganov/whisper.cpp}" "$whisper_cpp_commit"
cmake_steps "${whisper_flags[@]}"
mkdir -p "$install_prefix/bin"
cd ..
if [[ "${RAMALAMA_IMAGE_BUILD_DEBUG_MODE:-}" != y ]]; then
rm -rf whisper.cpp
Expand All @@ -243,8 +242,6 @@ clone_and_build_whisper_cpp() {

clone_and_build_llama_cpp() {
local llama_cpp_commit="${LLAMA_CPP_PULL_REF:-$DEFAULT_LLAMA_CPP_COMMIT}"
local install_prefix
install_prefix=$(set_install_prefix)
git_clone_specific_commit "${LLAMA_CPP_REPO:-https://github.com/ggml-org/llama.cpp}" "$llama_cpp_commit"
cmake_steps "${common_flags[@]}"
install -m 755 build/bin/rpc-server "$install_prefix"/bin/rpc-server
Expand Down
Loading