Skip to content

Bugs dest #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RohitKini merged 3 commits into from
Aug 30, 2024
Merged

Bugs dest #255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae74707
solved bugs
snehalsankhe Aug 29, 2024
60a7438
merged from dev
snehalsankhe Aug 29, 2024
123073f
optimised code
snehalsankhe Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
solved bugs
  • Loading branch information
@snehalsankhe
snehalsankhe committed Aug 29, 2024
commit ae7470750c6f7ae8cd66c52c145ba24673403768
17 changes: 15 additions & 2 deletions ui/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Suspense } from 'react';
import { Suspense, useEffect } from 'react';
import { Provider } from 'react-redux';
import { PersistGate } from 'redux-persist/integration/react';
import { FullPageLoader } from '@contentstack/venus-components';
Expand All @@ -18,6 +18,20 @@ import { useNetworkCheck } from './components/NetworkProvider';
function App() {
const isOnline = useNetworkCheck();

useEffect(() => {
const selectModal = document.querySelector('.ReactModalPortal');

if (selectModal instanceof HTMLElement) {
if (!isOnline) {
// Hide the modal by setting display to none
selectModal.style.display = 'none';
} else {
// Show the modal by setting display to block (or its original value)
selectModal.style.display = 'block';
}
}
}, [isOnline]);

return (
<>
{isOnline ? (
Expand All @@ -38,5 +52,4 @@ function App() {
</>
);
}

export default App;
1 change: 1 addition & 0 deletions ui/src/components/DestinationStack/DestinationStack.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
background-color: $color-brand-white-base;
.description {
line-height: 24px;
font-family: $font-family-primary;
}
.step_block {
padding: 0 !important;
Expand Down