Skip to content

Conversation

@AishDani
Copy link
Contributor

No description provided.

@AishDani AishDani requested a review from sayalijoshi27 April 23, 2024 05:53
.non-localizable-message {
margin-top: 0;
margin-left: 30px;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this file as AdvanceProperties

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

);
};

export default AdvanceSettings;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this as AdvanceProperties

<Select
id={data.uid}
value={{ label: data.ContentstackFieldType, value: fieldValue }}
onChange={(selectedOption: FieldTypes) => handleValueChange(selectedOption, data.uid)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ?.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<div className="select">
<Select
id={data.uid}
value={{ label: data.ContentstackFieldType, value: fieldValue }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ?.

<div className="table-row">
<div className="select">
<Select
id={data.uid}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ?.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AishDani AishDani requested a review from sayalijoshi27 April 23, 2024 09:16
@sayalijoshi27 sayalijoshi27 merged commit dbeccea into dev Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants