Skip to content

feat(prompt): rewrite codebase to use inquirer - UPDATED with current master #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
escapedcat merged 11 commits into from
Nov 6, 2021
Merged

feat(prompt): rewrite codebase to use inquirer - UPDATED with current master #2697

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ee85195
feat(prompt): rewrite codebase to use inquirer
armano2 Jan 4, 2021
453127b
fix(prompt): simplify logic used to compute maxLength
armano2 Jan 6, 2021
be7ca41
test(prompt): add basic input test
armano2 Jan 6, 2021
7fcf591
fix(prompt): small code refactor
armano2 Jan 8, 2021
9709318
fix: correct linting issues, add missing dependencies
armano2 Jan 12, 2021
c456add
fix: add missing tsconfig reference
armano2 Jan 12, 2021
1f912c2
fix: update lock file after merge
armano2 Jan 20, 2021
c285805
fix: correct issue with mac-os tab completion
armano2 Jan 20, 2021
b822c33
chore: code review
escapedcat Aug 1, 2021
8ec7866
fix: integrate review feedback
escapedcat Sep 29, 2021
36eb465
style: prettier
escapedcat Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(prompt): simplify logic used to compute maxLength
  • Loading branch information
@armano2 @escapedcat
armano2 authored and escapedcat committed Nov 2, 2021
commit 453127bdf3fb650bc66ff269e8caeafb7ed1ae85
19 changes: 10 additions & 9 deletions @commitlint/prompt/src/library/get-prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@ export default function getPrompt(
},
tabCompletion: enumRule
? enumRule[1][2].map((enumerable) => {
const value = forceLeadingBlankFn(forceCaseFn(enumerable));
const enumSettings = (settings.enumerables || {})[enumerable] || {};
return {
value: value,
value: forceLeadingBlankFn(forceCaseFn(enumerable)),
description: enumSettings.description || '',
};
})
Expand All @@ -92,13 +91,15 @@ export default function getPrompt(
return prefix + EOL;
},
maxLength(res: Result) {
const headerLength = settings.header ? settings.header.length : Infinity;
const header = `${res.type}${res.scope ? `(${res.scope})` : ''}${
res.type || res.scope ? ': ' : ''
}${res.subject}`;
const remainingHeaderLength = headerLength
? headerLength - header.length
: Infinity;
let remainingHeaderLength = Infinity;
if (settings.header && settings.header.length) {
const header = format({
type: res.type,
scope: res.scope,
subject: res.subject,
});
remainingHeaderLength = settings.header.length - header.length;
}
return Math.min(inputMaxLength, remainingHeaderLength);
},
transformer(value: string) {
Expand Down