docs(ci): add GitHub Actions section #3558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escapedcat
reviewed
Mar 6, 2023
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Install required dependencies | ||
| run: | |
There was a problem hiding this comment.
Can this be switched to use the node action?
Something liek this?
- uses: actions/setup-node@v3
with:
node-version: "14"
cache: "yarn"
There was a problem hiding this comment.
sure, I can change it if you want, but:
- I'm not a fan of that. Reason is that I like CI steps to be copy-pastable by the devs in case they want to try to replicate in their local machines what CI is doing; and that setup-node thing would be a black box
- I wouldn't have tested it, but the YML I have added comes from a repo of mine which is tested
There was a problem hiding this comment.
Hm, fair enough. Let's go with this then. Thanks for your feedback.
Merged
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.