Skip to content

Conversation

@brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Oct 14, 2023

Description

Lazy load cosmiconfig-typescript-loader

Motivation and Context

To avoid loading cosmiconfig-typescript-loader (and consequently ts-node/jiti) when not required (i.e. when the user has no typescript-based config file). Refer #3256 (comment). This unblocks the users facing #3256 and improves perf.

How Has This Been Tested?

Manually tested on my project with the patch. The CI already has tests for TS-based config.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Thanks @brc-dd !

@escapedcat escapedcat merged commit b058c7c into conventional-changelog:master Oct 14, 2023
@escapedcat
Copy link
Member

https://github.com/conventional-changelog/commitlint/releases/tag/v17.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants