fix: add TypeScript support and configuration for pnpm scopes #4544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
JounQin
suggested changes
Aug 29, 2025
|
oops yea will remove that. |
|
Awesome! Thanks! 👏 |
escapedcat
merged commit ea75778
into
conventional-changelog:master
12 of 13 checks passed
This was referenced Aug 29, 2025
knocte
reviewed
Aug 31, 2025
| "declaration": true, | ||
| "outDir": "dist", | ||
| "rootDir": "/", | ||
| "strict": true, |
There was a problem hiding this comment.
@alsmadi99 why remove strict:true?
There was a problem hiding this comment.
this was to just follow standard of other ts modules in @commitlint like the validator module. as at first when i wrote it i just put the default tsconfig i found online.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing dist files for
@commitlint/config-pnpm-scopesby adding it to root tsconfig references, prepublishOnly script, and Docker CI pack step.Motivation and Context
Resolves #4543
How Has This Been Tested?
By running build and test commands on both main repo and sub module
Types of changes
Checklist: