Skip to content

fix: upgrade babel from 6 to 7 #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 26, 2020
Merged

fix: upgrade babel from 6 to 7 #886

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4d3e7ba
feat: upgrade babel from 6 to 7
armano2 Jan 3, 2020
d8633d1
fix: add promise.finally
armano2 Jan 3, 2020
61f9f05
fix: rollback mistaken execa upgrade
armano2 Jan 3, 2020
85762ec
Merge remote-tracking branch 'upstream/master' into upgrade-babel
armano2 Jan 3, 2020
741aade
chore: update rule names (import)
armano2 Jan 3, 2020
12c17ee
test: remove unnecessary arrow function
armano2 Jan 3, 2020
b76937f
chore: remove unnecessary `/index`
armano2 Jan 3, 2020
3ca5fd1
chore: remove some leftovers from merge conflict
armano2 Jan 3, 2020
eba4002
test: drop unnecessary notThrowsAsync
armano2 Jan 3, 2020
fb89e2d
Revert "test: drop unnecessary notThrowsAsync"
armano2 Jan 3, 2020
09dd193
fix: drop some trash files after merge
armano2 Jan 4, 2020
d678d64
Merge branch 'master'
armano2 Jan 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "test: drop unnecessary notThrowsAsync" 
This reverts commit eba4002.
  • Loading branch information
@armano2
armano2 committed Jan 3, 2020
commit fb89e2d1bf8d397bef7d0215f6466d6e3cf2ebc5
125 changes: 71 additions & 54 deletions @commitlint/cli/src/cli.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,70 +136,85 @@ test('should produce no error output with -q flag', async t => {
});

test('should work with husky commitmsg hook and git commit', async t => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg({husky: {hooks: {'commit-msg': `'${bin}' -e`}}}, {cwd});
await t.notThrowsAsync(async () => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg({husky: {hooks: {'commit-msg': `'${bin}' -e`}}}, {cwd});

await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
});
});

test('should work with husky commitmsg hook in sub packages', async t => {
const upper = await git.bootstrap('fixtures/husky');
const cwd = path.join(upper, 'integration');
await writePkg({husky: {hooks: {'commit-msg': `'${bin}' -e`}}}, {cwd: upper});
await t.notThrowsAsync(async () => {
const upper = await git.bootstrap('fixtures/husky');
const cwd = path.join(upper, 'integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e`}}},
{cwd: upper}
);

await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
});
});

test('should work with husky via commitlint -e $GIT_PARAMS', async t => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e $GIT_PARAMS`}}},
{cwd}
);
await t.notThrowsAsync(async () => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e $GIT_PARAMS`}}},
{cwd}
);

await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
});
});

test('should work with husky via commitlint -e %GIT_PARAMS%', async t => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e %GIT_PARAMS%`}}},
{cwd}
);
await t.notThrowsAsync(async () => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e %GIT_PARAMS%`}}},
{cwd}
);

await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
});
});

test('should work with husky via commitlint -e $HUSKY_GIT_PARAMS', async t => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e $HUSKY_GIT_PARAMS`}}},
{cwd}
);
await t.notThrowsAsync(async () => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e $HUSKY_GIT_PARAMS`}}},
{cwd}
);

await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
});
});

test('should work with husky via commitlint -e %HUSKY_GIT_PARAMS%', async t => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e %HUSKY_GIT_PARAMS%`}}},
{cwd}
);
await t.notThrowsAsync(async () => {
const cwd = await git.bootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e %HUSKY_GIT_PARAMS%`}}},
{cwd}
);

await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa('git', ['commit', '-m', '"test: this should work"'], {cwd});
});
});

test('should allow reading of environment variables for edit file, succeeding if valid', async t => {
Expand Down Expand Up @@ -276,17 +291,19 @@ test('should pick up config from inside git repo with precedence and fail accord
});

test('should handle --amend with signoff', async t => {
const cwd = await git.bootstrap('fixtures/signoff');
await writePkg({husky: {hooks: {'commit-msg': `'${bin}' -e`}}}, {cwd});

await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa(
'git',
['commit', '-m', '"test: this should work"', '--signoff'],
{cwd}
);
await execa('git', ['commit', '--amend', '--no-edit'], {cwd});
await t.notThrowsAsync(async () => {
const cwd = await git.bootstrap('fixtures/signoff');
await writePkg({husky: {hooks: {'commit-msg': `'${bin}' -e`}}}, {cwd});

await execa('npm', ['install'], {cwd});
await execa('git', ['add', 'package.json'], {cwd});
await execa(
'git',
['commit', '-m', '"test: this should work"', '--signoff'],
{cwd}
);
await execa('git', ['commit', '--amend', '--no-edit'], {cwd});
});
});

test('should handle linting with issue prefixes', async t => {
Expand Down