This repository was archived by the owner on Feb 5, 2020. It is now read-only.
platforms/aws: apply tags to internal route53 zone #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sym3tri
approved these changes
May 2, 2017
Contributor
sym3tri
left a comment
sym3tri
left a comment
There was a problem hiding this comment.
Jenkins is happy. Code LGTM, it's just a copy/paste from other blocks.
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 21, 2018
We've been tagging our internal zone since 75fb49a (platforms/aws: apply tags to internal route53 zone, 2017-05-02, coreos/tectonic-installer#465). Tagging this resource makes it easier to cleanup resource leaks, because the resource is more obviously associated with the given cluster (and you can use extra_tags to set expirationDate, etc.).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jan 11, 2019
Centralize extra-tag inclusion on aws/main.tf. This reduces the
number of places we need to think about what tags should be ;).
Also keep kubernetes.io/cluster/{name} localized in the aws module.
See 8a37f72 (modules/aws/bootstrap: Pull AWS bootstrap setup into a
module, 2018-09-05, openshift#217) for why we need to keep it on the bootstrap
instance. But the bootstrap resources will be removed after the
bootstrap-complete event comes through, and we don't want Kubernetes
controllers trying to pick them up.
This commit updates the internal Route 53 zone from KubernetesCluster
to kubernetes.io/cluster/{name}: owned, catching it up to
kubernetes/kubernetes@0b5ae539 (AWS: Support shared tag, 2017-02-18,
kubernetes/kubernetes#41695). That tag originally landed on the zone
back in 75fb49a (platforms/aws: apply tags to internal route53 zone,
2017-05-02, coreos/tectonic-installer#465).
Only the master instances need the clusterid tag, as described in
6c7a5f0 (Tag master machines for adoption by machine controller,
2018-10-17, openshift#479).
A number of VPC resources have moved from "shared" to "owned". The
shared values are from 45dfc2b (modules/aws,azure: use the new tag
format for k8s 1.6, 2017-05-04, coreos/tectonic-installer#469). The
commit message doesn't have much to say for motivation, but Brad Ison
said [1]:
I'm not really sure if anything in Kubernetes actually uses the
owned vs. shared values at the moment, but in any case, it might
make more sense to mark subnets as shared. That was actually one of
the main use cases for moving to this style of tagging -- being able
to share subnets between clusters.
But we aren't sharing these resources; see 6f55e67 (terraform/aws:
remove option to use an existing vpc in aws, 2018-11-11, openshift#654).
[1]: coreos/tectonic-installer#469 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434