Skip to content

Return non zero exit code for ThresholdStatistic.Minimum even when no coverage #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2021
Merged

Return non zero exit code for ThresholdStatistic.Minimum even when no coverage #1206

merged 2 commits into from
Aug 5, 2021

Conversation

daveMueller
Copy link
Collaborator

closes #1205

MarcoRossignoli
MarcoRossignoli approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! Remember the changelog.

@MarcoRossignoli MarcoRossignoli merged commit 624ef0f into coverlet-coverage:master Aug 5, 2021
@daveMueller daveMueller deleted the 1205_ThresholdNotWorking branch August 8, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option --threshold doesn't work, coverage.json is empty
2 participants
@daveMueller @MarcoRossignoli