Skip to content

Conversation

@naga-karupi
Copy link

@naga-karupi naga-karupi commented Sep 22, 2023

Add Write(const char* const dataCharArray, size_t size) for #177.

I comfarmed it can be built.

I have not writen gtest yet. So please reply if I need to write gtest.

@mcsauder
Copy link
Collaborator

mcsauder commented Sep 3, 2025

Hi @naga-karupi , I'm sorry this has sat for so long. My initial concern about writing a char* led me to drag my feet and eventually forget about getting back to you. I apologize for that.

I've build and run your branch, everything is still functioning, but I don't have a unit test to verify your work. If you are still interested in this PR, would you be willing to add a unit test as you had asked about? It should be very straightforward, just add to this one or copy/paste a similar.

I will get it tested right away if you are able.

@crayzeewulf , any thoughts?

Thanks for your contribution @naga-karupi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants