Open
Conversation
rhyas
requested review from
a-klebanov,
michalbiesek,
sdball and
stevelitras
as code owners
Collaborator
|
@rhyas Can this be achieved using the existing |
Author
It cannot (that I have been able to figure out) because you cannot use ClaimTemplates to make this dynamic unless you deploy as a statefulset, which isn't recommended afaik, and probably wouldn't scale up/down nearly as cleanly. ClaimTemplates in deployment are the solution to this problem. In order to use these in deployments, one must use the ephemeral key type for the volume to make everything dynamic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use ephemeral volumes to the crible-workergroup chart. This makes it so you can have larger volumes for persistence data during upstream events without overloading your kubernetes nodes.
Chart [ logstream-workergroup ] helm-chart-sources/logstream-workergroup
PASS Deployment helm-chart-sources/logstream-workergroup/tests/daemonset_test.yaml
PASS Deployment helm-chart-sources/logstream-workergroup/tests/deployment_test.yaml
PASS Extras helm-chart-sources/logstream-workergroup/tests/extras_test.yaml
PASS Secret helm-chart-sources/logstream-workergroup/tests/hpa_test.yaml
PASS Ingress helm-chart-sources/logstream-workergroup/tests/ingress_test.yaml
PASS Labels helm-chart-sources/logstream-workergroup/tests/labels_test.yaml
PASS RBAC helm-chart-sources/logstream-workergroup/tests/rbac_test.yaml
PASS Secret helm-chart-sources/logstream-workergroup/tests/secret_test.yaml
PASS Deployment Security Context helm-chart-sources/logstream-workergroup/tests/securitycontext_test.yaml
PASS Service helm-chart-sources/logstream-workergroup/tests/service_test.yaml
PASS Service Account helm-chart-sources/logstream-workergroup/tests/serviceaccount_test.yaml
PASS Deployment helm-chart-sources/logstream-workergroup/tests/statefulset_test.yaml
PASS Volumes and Mounts helm-chart-sources/logstream-workergroup/tests/volumes_test.yaml
Charts: 1 passed, 1 total
Test Suites: 13 passed, 13 total
Tests: 91 passed, 91 total
Snapshot: 0 passed, 0 total
Time: 2.165598229s