-
Notifications
You must be signed in to change notification settings - Fork 3
Small fixes to create Items out of RDPS and HRDPS data sets #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to ensure uniqueness. Fix iterator in THREDDSLoader. Update CORDEX test data.
…eHelper for vertical coordinate extents. Split and clean script to update test data. Add tests for RDPS and HRDPS attributes with no custom extension.
fmigneault
reviewed
Jul 2, 2025
Collaborator
fmigneault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a run of ruff format.
fmigneault
reviewed
Jul 2, 2025
Merged
… Add module docstring to update_data.py
fmigneault
approved these changes
Jul 7, 2025
henriaidasso
added a commit
to henriaidasso/stac-populator
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDPS and HRDPS are the datasets used to train the spatial downscaling U-Net in the GeoConnexions project.
There are small test samples here:
https://pavics.ouranos.ca/twitcher/ows/proxy/thredds/catalog/birdhouse/testdata/HRDPS/catalog.html
This PR runs STAC item creation tests against those datasets. The only fixes needed to run the tests were
create_uidmethod in the THREDDSCatalogDataModel. Not doing so would mean having to create a custom extension for every dataset we want to add to the catalog. The default UID is just the location of the dataset relative to thefileserver/URL.[", "], now[None, None].Notes
In the DataCube 2.2.0 schema, the
vertical_spatial_dimensionhas a requiredextentdefined as