RDPS implementation with additional extensions #114
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -147,8 +147,9 @@ def create_stac_collection(self) -> dict[str, Any]: | |
| self._collection_info["providers"] = self.__make_collection_providers() | ||
|
|
||
| # Add contacts as extra_field | ||
| if "contacts" in self._collection_info: | ||
| self._collection_info["extra_fields"] = {} | ||
| self._collection_info["extra_fields"]["contacts"] = self.__make_collection_contacts() | ||
|
Comment on lines
+150
to
+153
Collaborator
There was a problem hiding this comment. Use helper. See other comment under https://github.com/crim-ca/stac-populator/pull/114/files/2e6a69eacfb0a554d51649df394e6c0a7492e935#r2414944345
Collaborator
Author
There was a problem hiding this comment. Not sure how using a helper (extending From what I understand, the helpers' I have the same question for adding information at the Asset/Link level. For now, I directly access the asset(s) from the item object (See my updates on the FileHelper: https://github.com/henriaidasso/stac-populator/blob/rdps/STACpopulator/extensions/file.py#L22-L31). But can't access the collection object from the item. I'm sure there is a better way for extending both collection and asset metadata. But the Also, for information added in the collection yaml file, how to go about integrating the schema validation uri? @huard or @mishaschwartz would you also have any suggestions for me on this.
Collaborator
There was a problem hiding this comment. There was not much done with the collection itself, since we were mostly dealing with per-item metadata, but I think we should keep that pattern for collections as well. The feature would need to be added. It would be very similar to the Assets and links could be the same, but I have an impression they should be dealt with at the same time as the Normally, if a STAC extension applies to Collections, the same schema as the Item's would be used (they all have some When the Collection/Item are "core" properties, their schemas are the ones under https://github.com/radiantearth/stac-spec (see |
||
|
|
||
| # Construct links if provided in the config. This needs to be done before constructing a collection object. | ||
| collection_links = self.__make_collection_links() | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be combined into a generic helper to deal with top-level "STAC core" properties (
license,providers,keywords, etc.)@mishaschwartz
Maybe coordinate in this effort. I know you were checking out
summariesgeneration. It could be within the same "CoreHelper".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can coordinate about that.
I'll have time to dedicate to that after the 20th so let's chat about it then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mishaschwartz so would you be available this week to discuss this feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Please send me an email with some times you're free to meet. (@fmigneault can give you my work email, I'd rather not post it here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when you plan to meet. I am interested to hear about the feature as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @henriaidasso I'm just circling back to this. Please let me know if you'd still like to meet about this question. Since this was last discussed, #106 has been accepted.